Merge branch 'next' into next-improve-extraction-test

curiosone-bot · Oct 22, 2017 · ac8a209 · ac8a209
2 parents cf7e350 + 4ae65f0
commit ac8a209
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 63 deletions.
diff --git a/src/test/java/com/github/bot/curiosone/core/knowledge/SemanticQueryTest.java b/src/test/java/com/github/bot/curiosone/core/knowledge/SemanticQueryTest.java
@@ -94,51 +94,6 @@ public void testEqualsReflexive() {
     assertThat(sq).isEqualTo(sq);
   }
 
-  /*
-  TODO: fix null arguments in SemanticQuery constructors.
-  @Test
-  public void testEqualsSymmetric() {
-    SemanticQuery sq = new SemanticQuery(SemanticRelationType.SIMILAR_TO, "a", "b");
-    SemanticQuery sqq = new SemanticQuery(SemanticRelationType.SIMILAR_TO, "a", "b");
-    assertThat(sq).isEqualTo(sqq);
-    assertThat(sqq).isEqualTo(sq);
-
-    sq = new SemanticQuery(SemanticRelationType.TIME, "a", "b", "c");
-    sqq = new SemanticQuery(SemanticRelationType.TIME, "a", "b", "c");
-    assertThat(sq).isEqualTo(sqq);
-    assertThat(sqq).isEqualTo(sq);
-
-    sq = new SemanticQuery(SemanticRelationType.IS_PERSON, "", "", "");
-    sqq = new SemanticQuery(SemanticRelationType.IS_PERSON, "", "", "");
-    assertThat(sq).isEqualTo(sqq);
-    assertThat(sqq).isEqualTo(sq);
-  }
-
-  @Test
-  public void testEqualsTransitive() {
-    SemanticQuery sq = new SemanticQuery(SemanticRelationType.SIMILAR_TO, "a", "b");
-    SemanticQuery sqq = new SemanticQuery(SemanticRelationType.SIMILAR_TO, "a", "b");
-    SemanticQuery sqqq = new SemanticQuery(SemanticRelationType.SIMILAR_TO, "a", "b");
-    assertThat(sq).isEqualTo(sqq);
-    assertThat(sqq).isEqualTo(sqqq);
-    assertThat(sqqq).isEqualTo(sq);
-
-    sq = new SemanticQuery(SemanticRelationType.REGION, "+-", "*:");
-    sqq = new SemanticQuery(SemanticRelationType.REGION, "+-", "*:");
-    sqqq = new SemanticQuery(SemanticRelationType.REGION, "+-", "*:");
-    assertThat(sq).isEqualTo(sqq);
-    assertThat(sqq).isEqualTo(sqqq);
-    assertThat(sqqq).isEqualTo(sq);
-
-    sq = new SemanticQuery(SemanticRelationType.ENTAILMENT, "a", "b");
-    sqq = new SemanticQuery(SemanticRelationType.ENTAILMENT, "a", "b");
-    sqqq = new SemanticQuery(SemanticRelationType.ENTAILMENT, "a", "b");
-    assertThat(sq).isEqualTo(sqq);
-    assertThat(sqq).isEqualTo(sqqq);
-    assertThat(sqqq).isEqualTo(sq);
-  }
-  */
-
   @Test
   public void testEqualsCoherent() {
     SemanticQuery sq =

diff --git a/src/test/java/com/github/bot/curiosone/core/nlp/PhraseTest.java b/src/test/java/com/github/bot/curiosone/core/nlp/PhraseTest.java
@@ -98,24 +98,6 @@ public void testExtract() {
     assertThat(extract("a. bcd")).hasSize(2);
 
     assertThat(extract("a.b. ,c!")).hasSize(3);
-
-    /*
-    TODO: fix NullPointerException;
-
-    assertThat(extract("###")).hasSize(1);
-
-    assertThat(extract("abc.   !")).hasSize(2);
-
-    assertThat(extract(". I live in Rome")).hasSize(2);
-
-    assertThat(extract(" . I live in Rome")).hasSize(2);
-
-    assertThat(extract("@.#.")).hasSize(0);
-
-    assertThat(extract(" ")).hasSize(0);
-
-    assertThat(extract(" . ")).hasSize(0);
-    */
   }
 
   @Test