options: fixes memory leak on API misuse #16599
Closed
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURLOPT_PROXYUSERPWD should not be used if CURLOPT_PROXYUSERNAME and/or CURLOPT_PROXYPASSWORD get used and vice versa
cmeister2
reviewed
Mar 6, 2025
| @@ -2140,6 +2140,10 @@ static CURLcode setopt_cptr(struct Curl_easy *data, CURLoption option, | |||
| /* | |||
| * user:password needed to use the proxy | |||
| */ | |||
| if(data->set.str[STRING_PROXYUSERNAME] || | |||
There was a problem hiding this comment.
Looking at some of the errors I think this code may need to come directly after the char * lines below.
This was referenced Mar 6, 2025
I don't believe this is true, nor documented. Can we create a test case first that proves this to be a problem? |
bagder
added a commit
that referenced
this pull request
Mar 6, 2025
Prevent the previous memory leak. Adjusted test 590 to reproduce the problem then verify the fix. Fixes #16599 Reported-by: Catena cyber
|
I prefer #16601 |
|
Analysis of PR #16599 at 2c479d12: Test 1521 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 93 different CI jobs (the link just goes to one of them). Generated by Testclutch |
|
Thanks for making a better fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURLOPT_PROXYUSERPWD should not be used if
CURLOPT_PROXYUSERNAME and/or CURLOPT_PROXYPASSWORD get used and vice versa
Will allow fuzzers to go past that with curl/curl-fuzzer#124 cc @cmeister2