-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSR-2066] feat: added full test suite generation for convert command #139
Conversation
c9d00d8
to
ee4ec7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Miguel, there is a little more work to be done here.
While testing I noticed a bug: if the groups contain the same spec names, the new created instances will overwrite the old ones and only the last group instances will be in the report directory. Check the video
Screencast.from.2025-02-06.10-42-17.mp4
…ommand. it allows multiple groups
ee4ec7e
to
eea7b2f
Compare
@vCaisim ready now, I fixed the bug of the same name instances being overwritten. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, the issue is solved. Please address the latest feedback and update the option description for the --input-file
so it is clear that it can accept multiple paths
return parsedXMLInputs; | ||
} | ||
|
||
const getParsedXMLInput = async (XMLString: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getParsedXMLInput
, don't trim 2 times, use a variable- it returns
undefined
ifXMLString
is emtpy string orparsedXMLInput
is falsy value andgetParsedXMLArray
ends up with[undefined]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first point is done.
The second point:
I'm applying a .filter(Boolean);
to the array after it is finished to remove the possible undefined
elements. This is in line 14 of the same file.
Thanks for the feedback. Everything is addressed now :) |
Description
This PR add the fullTestSuite.json file generation to the convert command.
It also allows generating multiple groups for the full test suite by accepting multiple files as different test groups.
PR Checklist
Release Plan
Demo
https://www.loom.com/share/02ef05e48df64832a7cb884c960db874?sid=60ea25b0-e032-4e73-b888-1d0b0dffe6c3
Manual Testing