Lint to prevent floating promises #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…less into noFloatingPromises
pokey
reviewed
Jul 28, 2024
AndreasArvidsson
requested review from
saidelike and
fidgetingbits
as code owners
pokey
reviewed
Jul 30, 2024
packages/cursorless-engine/src/core/commandVersionUpgrades/upgradeV5ToV6/upgradeV5ToV6.ts
Outdated
Show resolved
Hide resolved
packages/cursorless-engine/src/core/commandVersionUpgrades/upgradeV5ToV6/upgradeV5ToV6.ts
Outdated
Show resolved
Hide resolved
packages/cursorless-vscode/src/ide/vscode/hats/FontMeasurementsImpl.ts
Outdated
Show resolved
Hide resolved
packages/cursorless-vscode/src/ide/vscode/hats/VscodeHatRenderer.ts
Outdated
Show resolved
Hide resolved
|
Updated with your suggestions. Just be clear in many cases I just put void because I assume that you would be awaiting things like the tutorial if it actually was important. |
I think in a lot of those cases it only returns a promise to allow for other IDEs; I believe VSCode just resolves immediately |
pokey
approved these changes
Jul 30, 2024
|
I'm also running this locally |
pokey
force-pushed
the
noFloatingPromises
branch
from
1c9acf8 to
1486cd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1984
Note that I just mechanically went through all the errors and tried to fix them. We definitely need to look at the change log and decide if we like the changes. Maybe we should add a few more if statements with throw instead of asserting not now and so on.
Checklist