Added iteration scope for python arguments #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillco
approved these changes
Jan 25, 2025
| "(" @argumentOrParameter.iteration.start.endOf | ||
| ")" @argumentOrParameter.iteration.end.startOf | ||
| ) @argumentOrParameter.iteration.domain | ||
| "(" @argumentOrParameter.iteration.start.endOf @name.iteration.start.endOf @value.iteration.start.endOf |
There was a problem hiding this comment.
NB: Andreas says there's a limit of three captures on each node and more are silently discarded by tree-sitter, so beware.
There was a problem hiding this comment.
Ideally we should lint this - or adding to SCM tests
| @@ -7,10 +7,16 @@ export const pythonScopeSupport: LanguageScopeSupportFacetMap = { | |||
| "name.foreach": supported, | |||
| "name.resource": supported, | |||
| "name.resource.iteration": supported, | |||
| "name.argument.actual": supported, | |||
There was a problem hiding this comment.
NB: we could extend this to other languages that support keyword arguments like ruby, but we need to have familiarity with them. A quick check of
Line 4 in b62d901
| @@ -0,0 +1,16 @@ | |||
| aaa(bbb=0, ccc=1) | |||
There was a problem hiding this comment.
Names come from compiler history -- an "actual" parameter is where it is passed, a formal parameter is where it is defined in the function definition (if there is one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2729
Checklist