Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add attribute field and display #55

Merged

Conversation

rohankapoorcom
Copy link
Member

Creating a new branch and PR since I can't fix the merge conflicts on @lizsugar's original PR (#8). Rebases their branch on top of mainline and then includes includes a doc update.

You can now define, via GUI or YAML, whether an attribute is to be displayed and which attribute to show.

image

This resolves the request in mattieha#175 and mattieha#158

image

lizsugar and others added 5 commits August 12, 2023 18:46
GUI and YAML options added, english translation added

Current bugs: if attribute value is too long, then state and attribute will
not stay on the same line.
@rohankapoorcom rohankapoorcom merged commit 96a83a2 into custom-cards:main Aug 13, 2023
2 checks passed
@rohankapoorcom rohankapoorcom deleted the lizsugar_display_attribute branch August 13, 2023 05:26
@ScottG489
Copy link

Thanks for adding this feature! Just wanted to quickly point out that I noticed the attribute isn't aligned vertically when in compact mode.

Let me know if you can't reproduce.

@rohankapoorcom
Copy link
Member Author

Thanks @ScottG489. Tracking in #58.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants