Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable jagged humidity values for some sensors #252

Closed
wants to merge 1 commit into from
Closed

Add option to disable jagged humidity values for some sensors #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions custom_components/ble_monitor/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
from .const import (
DEFAULT_ROUNDING,
DEFAULT_DECIMALS,
DEFAULT_JAGGED,
DEFAULT_PERIOD,
DEFAULT_LOG_SPIKES,
DEFAULT_USE_MEDIAN,
Expand All @@ -45,6 +46,7 @@
DEFAULT_HCI_INTERFACE,
CONF_ROUNDING,
CONF_DECIMALS,
CONF_JAGGED,
CONF_PERIOD,
CONF_LOG_SPIKES,
CONF_USE_MEDIAN,
Expand Down Expand Up @@ -95,6 +97,7 @@
{
vol.Optional(CONF_ROUNDING, default=DEFAULT_ROUNDING): cv.boolean,
vol.Optional(CONF_DECIMALS, default=DEFAULT_DECIMALS): cv.positive_int,
vol.Optional(CONF_JAGGED, default=DEFAULT_JAGGED): cv.boolean,
vol.Optional(CONF_PERIOD, default=DEFAULT_PERIOD): cv.positive_int,
vol.Optional(CONF_LOG_SPIKES, default=DEFAULT_LOG_SPIKES): cv.boolean,
vol.Optional(CONF_USE_MEDIAN, default=DEFAULT_USE_MEDIAN): cv.boolean,
Expand Down
4 changes: 4 additions & 0 deletions custom_components/ble_monitor/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
from .const import (
DEFAULT_ROUNDING,
DEFAULT_DECIMALS,
DEFAULT_JAGGED,
DEFAULT_PERIOD,
DEFAULT_LOG_SPIKES,
DEFAULT_USE_MEDIAN,
Expand All @@ -32,6 +33,7 @@
DEFAULT_RESTORE_STATE,
CONF_ROUNDING,
CONF_DECIMALS,
CONF_JAGGED,
CONF_PERIOD,
CONF_LOG_SPIKES,
CONF_USE_MEDIAN,
Expand Down Expand Up @@ -76,6 +78,7 @@
): cv.boolean,
vol.Optional(CONF_ROUNDING, default=DEFAULT_ROUNDING): cv.boolean,
vol.Optional(CONF_DECIMALS, default=DEFAULT_DECIMALS): cv.positive_int,
vol.Optional(CONF_JAGGED, default=DEFAULT_JAGGED): cv.boolean,
vol.Optional(CONF_LOG_SPIKES, default=DEFAULT_LOG_SPIKES): cv.boolean,
vol.Optional(CONF_USE_MEDIAN, default=DEFAULT_USE_MEDIAN): cv.boolean,
vol.Optional(CONF_RESTORE_STATE, default=DEFAULT_RESTORE_STATE): cv.boolean,
Expand Down Expand Up @@ -275,6 +278,7 @@ def _show_main_form(self, errors=None):
): cv.boolean,
vol.Optional(CONF_ROUNDING, default=self.config_entry.options.get(CONF_ROUNDING, DEFAULT_ROUNDING)): cv.boolean,
vol.Optional(CONF_DECIMALS, default=self.config_entry.options.get(CONF_DECIMALS, DEFAULT_DECIMALS)): cv.positive_int,
vol.Optional(CONF_JAGGED, default=self.config_entry.options.get(CONF_JAGGED, DEFAULT_JAGGED)): cv.boolean,
vol.Optional(CONF_LOG_SPIKES, default=self.config_entry.options.get(CONF_LOG_SPIKES, DEFAULT_LOG_SPIKES)): cv.boolean,
vol.Optional(CONF_USE_MEDIAN, default=self.config_entry.options.get(CONF_USE_MEDIAN, DEFAULT_USE_MEDIAN)): cv.boolean,
vol.Optional(CONF_RESTORE_STATE, default=self.config_entry.options.get(CONF_RESTORE_STATE, DEFAULT_RESTORE_STATE)): cv.boolean,
Expand Down
2 changes: 2 additions & 0 deletions custom_components/ble_monitor/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# Configuration options
CONF_ROUNDING = "rounding"
CONF_DECIMALS = "decimals"
CONF_JAGGED = "jagged"
CONF_PERIOD = "period"
CONF_LOG_SPIKES = "log_spikes"
CONF_USE_MEDIAN = "use_median"
Expand All @@ -21,6 +22,7 @@
# Default values for configuration options
DEFAULT_ROUNDING = True
DEFAULT_DECIMALS = 1
DEFAULT_JAGGED = True
DEFAULT_PERIOD = 60
DEFAULT_LOG_SPIKES = False
DEFAULT_USE_MEDIAN = False
Expand Down
3 changes: 2 additions & 1 deletion custom_components/ble_monitor/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
from .const import (
CONF_ROUNDING,
CONF_DECIMALS,
CONF_JAGGED,
CONF_PERIOD,
CONF_LOG_SPIKES,
CONF_USE_MEDIAN,
Expand Down Expand Up @@ -516,7 +517,7 @@ def __init__(self, config, mac, devtype):
self._device_class = DEVICE_CLASS_HUMIDITY
# LYWSD03MMC / MHO-C401 "jagged" humidity workaround
if devtype in ('LYWSD03MMC', 'MHO-C401'):
self._jagged = True
self._jagged = config[CONF_JAGGED]


class MoistureSensor(MeasuringSensor):
Expand Down
2 changes: 2 additions & 0 deletions custom_components/ble_monitor/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"discovery": "Discovery",
"rounding": "Rounding",
"decimals": "Decimals",
"jagged": "Jagged humidity for LYWSD03MMC and MHO-C401",
"period": "Period",
"log_spikes": "Log spikes",
"use_median": "Use median",
Expand Down Expand Up @@ -48,6 +49,7 @@
"discovery": "Discovery",
"rounding": "Rounding",
"decimals": "Decimals",
"jagged": "Jagged humidity for LYWSD03MMC and MHO-C401",
"period": "Period",
"log_spikes": "Log spikes",
"use_median": "Use median",
Expand Down
2 changes: 2 additions & 0 deletions custom_components/ble_monitor/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"discovery": "Discovery",
"rounding": "Rounding",
"decimals": "Decimals",
"jagged": "Jagged humidity for LYWSD03MMC and MHO-C401",
"period": "Period",
"log_spikes": "Log spikes",
"use_median": "Use median",
Expand Down Expand Up @@ -48,6 +49,7 @@
"discovery": "Discovery",
"rounding": "Rounding",
"decimals": "Decimals",
"jagged": "Jagged humidity for LYWSD03MMC and MHO-C401",
"period": "Period",
"log_spikes": "Log spikes",
"use_median": "Use median",
Expand Down