Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide mask during editing #8554
base: develop
Are you sure you want to change the base?
Hide mask during editing #8554
Changes from 6 commits
b1b89e7
dc04778
65a13b2
0684a9a
c6aecf3
60005d0
a47e5e7
c7a2ac2
0b81b8b
dd28e80
2f8f8db
15d0c0b
58f970a
920dbc1
0610dd4
cc3a215
70b65cf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1309 in cvat-canvas/src/typescript/drawHandler.ts
GitHub Actions / Linter
Check warning on line 1319 in cvat-canvas/src/typescript/drawHandler.ts
GitHub Actions / Linter
Check warning on line 1345 in cvat-canvas/src/typescript/drawHandler.ts
GitHub Actions / Linter
Check warning on line 229 in cvat-canvas/src/typescript/masksHandler.ts
GitHub Actions / Linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have three actions
changeHideEditedStateAsync
,updateEditedStateAsync
,resetEditedStateAsync
doing the same thing (updating the same key in store).Probably we may combine them to reduce the code duplication. Let it accept
shapeType
,objectState
andisHidden
. And use these arguments to update store and objectState properlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering my general review comment it should only accept
objectState: ObjectState | null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dispatch(resetEditedState())
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really relevant considering my other comment with proposal to combine actions