-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds proof support for the pythonic API #99
Conversation
(ASSUME: a + 2 == 0, [a + 2 == 0]), | ||
(MACRO_SR_EQ_INTRO: (a + 2 == 0) == (a == -2), | ||
[a + 2 == 0, 7, 12])))))) | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test for the exception, like here.
cvc5_pythonic_api/cvc5_pythonic.py
Outdated
return obj_to_string(self) | ||
|
||
def getRule(self): | ||
"""Returns the proof rule used by the root step of the proof.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test.
It's great to have a standalone test, but the doctests also are important, since they become (tested) documentation.
cvc5_pythonic_api/cvc5_pythonic.py
Outdated
return self.proof.getRule() | ||
|
||
def getResult(self): | ||
"""Returns the conclusion of the root step of the proof.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test.
cvc5_pythonic_api/cvc5_pythonic.py
Outdated
|
||
def getChildren(self): | ||
"""Returns the premises, i.e., proofs themselvels, of the root step of | ||
the proof.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test
cvc5_pythonic_api/cvc5_pythonic.py
Outdated
|
||
def getArguments(self): | ||
"""Returns the arguments of the root step of the proof as a list of | ||
expressions.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test.
test/pgms/proof.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks.
No description provided.