Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds proof support for the pythonic API #99

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Conversation

HanielB
Copy link
Member

@HanielB HanielB commented Jun 24, 2024

No description provided.

(ASSUME: a + 2 == 0, [a + 2 == 0]),
(MACRO_SR_EQ_INTRO: (a + 2 == 0) == (a == -2),
[a + 2 == 0, 7, 12]))))))
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test for the exception, like here.

return obj_to_string(self)

def getRule(self):
"""Returns the proof rule used by the root step of the proof."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test.

It's great to have a standalone test, but the doctests also are important, since they become (tested) documentation.

return self.proof.getRule()

def getResult(self):
"""Returns the conclusion of the root step of the proof."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test.


def getChildren(self):
"""Returns the premises, i.e., proofs themselvels, of the root step of
the proof."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test


def getArguments(self):
"""Returns the arguments of the root step of the proof as a list of
expressions."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Copy link
Member

@alex-ozdemir alex-ozdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@HanielB HanielB merged commit be54c23 into cvc5:main Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants