Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle system call return values in oracle runner #29

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Handle system call return values in oracle runner #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/base/run.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,15 @@ int run(const std::string& call,
{
int read_pipe[2];
int write_pipe[2];
pipe(read_pipe);
pipe(write_pipe);
if (pipe(read_pipe))
{
// Creating the pipe failed.
return -1;
}
if (pipe(write_pipe))
{
return -1;
}

pid_t pid = fork();
if (pid == -1)
Expand Down Expand Up @@ -60,7 +67,17 @@ int run(const std::string& call,
close(write_pipe[0]);
close(read_pipe[1]);

write(write_pipe[1], content.c_str(), content.length() + 1);
ssize_t written =
write(write_pipe[1], content.c_str(), content.length() + 1);
// Error cases: -1 is explicit error, or it's an incomplete write.
// Second case we could write more bytes, but we are writing to a pipe. So
// something odd must have happened.
if (written == -1 || written != static_cast<ssize_t>(content.length()) + 1)
{
close(write_pipe[1]);
close(read_pipe[0]);
return -1;
}
// Wait for child and get return code
int status;
pid_t ret;
Expand Down
Loading