-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#81/bug/fix cache problem #104
Merged
Merged
+106
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docker-compose.yaml
gatheluck
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my late review! LGTM!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue URL
close #81
Change overview
docker/bake-action
instead of running the rawdocker buildx bake
commandHow to test
I conducted experiments on a forked repository, so please refer to it for verification. The experiment details and checklist for each item are as follows:
cache-BuildCache-only
.See this pull request for the result below.
Make an appropriate edit on the
test/create-first-cache
branch and observe the behavior of thelint-and-test
workflow when a pull request is created against thecache-BuildCache-only
branch.lint-and-test
workflow, the build is performed without using cache.Observe the behavior of the
cache
workflow whentest/create-first-cache
is merged into thecache-BuildCache-only
branch.cache
workflow, the build process runs to cache the build cache.See this pull request for the result below.
Make an appropriate edit on the
test/use-existing-cache
branch and observe the behavior of thelint-and-test
workflow when a pull request is created against thecache-BuildCache-only
branch.lint-and-test
workflow, the build is performed using cache.Observe the behavior of the
cache
workflow whentest/use-existing-cache
is merged into thecache-BuildCache-only
branch.cache
workflow, almost all processing is skipped since build cache already exists.See this pull request for the result below.
Edit
environments/ci/docker-compose.yaml
on thetest/create-another-cache
branch and observe the behavior of thelint-and-test
workflow when a pull request is created against thecache-BuildCache-only
branch.lint-and-test
workflow, the build is performed without using the existing cache due to changes in environment-related files.Observe the behavior of the
cache
workflow whentest/create-another-cache
is merged into thecache-BuildCache-only
branch.cache
workflow, the build process runs to cache the new build cache.Note for reviewers
Note
As the cache will be removed in 7 days if not used, please check the result as soon as possible.