Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add poethepoet as task runner #114

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Add poethepoet as task runner #114

merged 6 commits into from
Aug 23, 2024

Conversation

gatheluck
Copy link
Contributor

@gatheluck gatheluck commented Aug 5, 2024 •
edited
Loading

Issue URL

#100

Change overview

Use Poe the Poet as task runner instead of Make.

How to test

# Please test following inside of container
% poe lint # same as `make lint`
% poe format # same as `make format`
% poe test-all # same as `make test-all`

Note for reviewers

NA

@gatheluck gatheluck self-assigned this Aug 9, 2024
@gatheluck gatheluck marked this pull request as ready for review August 9, 2024 03:24
@gatheluck gatheluck added the enhancement New feature or request label Aug 9, 2024
YoshikiKubotani
YoshikiKubotani requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@YoshikiKubotani YoshikiKubotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the minor typo

environments/Dockerfile Outdated Show resolved Hide resolved
YoshikiKubotani
YoshikiKubotani approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@YoshikiKubotani YoshikiKubotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatheluck gatheluck merged commit d1f9e6c into develop Aug 23, 2024
5 checks passed
@gatheluck gatheluck mentioned this pull request Aug 23, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshikiKubotani YoshikiKubotani YoshikiKubotani approved these changes

Assignees

@gatheluck gatheluck

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gatheluck @YoshikiKubotani