-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub Actions & Pytest #45
Conversation
Thanks @phschiele!
|
name: build
on:
pull_request:
push:
branches:
- master
tags:
- '*'
jobs:
cleanup-runs:
runs-on: ubuntu-latest
steps:
- uses: rokroskar/workflow-run-cleanup-action@master
env:
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master'" |
Will this run on PRs? |
@sbarratt Yes, the idea is to run the build incl. tests on every PR. Building wheels and deploying to PYPI will only be done whenever a new tag is created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo the workflows not running. Will look into that ...
That appears to be the case: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks However, the documentation says that I should see an option to approve your workflow and run it on this PR, which I do not. (I approved the PR to see if the option would show up.) All I see is the following These links might be helpful: |
@akshayka The GH Actions are running (and passing) now. |
Looks good, thanks @phschiele! |
Hi @akshayka !
this PR addresses #43 and #44. It also switches from
nose
topytest
, I hope that's fine with you.Some remaining open points:
test_threading
fails under ubuntu & Python 3.6 (under nose and pytest, relative tolerance is1e-7
, maximum relative difference is1e-5
)scipy=1.3 numpy=1.16
combo from cvxpy did not work.