Add autoload-dev and remove all require_once in tests #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All non-namespaced classes in JsonMapperTest are made part of the PSR0 autoloading. Exception still made for the "Zoo" collection of classes.
|
Thanks. Long overdue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe we should utilize the composer autoloading for development purposes. Tests won't run without Composer anyways.
I decided to put any class that is used inside a test into the
tests/supportfolder, clearly separating them from the test cases.Inside we have a
JsonMapperTestfolder for any namespace-less classes, autoloaded with PSR-0. As an exception, theZoofolder is also namespaceless, but hasn't been renamed yet. Everything else is PSR-4 autoloaded (namespacetest, othernamespace and Enums).Some moved classes were renamed to fit inside the JsonMapperTest schema. In addition, some underscores were removed because they conflict with how PSR-0 works, and would require useless subfolders.