Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condense assertions #232

Closed
wants to merge 3 commits into from
Closed

Condense assertions #232

wants to merge 3 commits into from

Commits on Mar 21, 2024

  1. Condense assertions 

    Use assertSame to validate both type and value in one step.
Use assertCount to check number of array elements.
Use assertContainsOnly(InstanceOf) to check type of array elements.

Tiny cleanup for tests that are only run for PHP 7.0 or 7.1 and up,
as they need no check for the PHP version anymore.

Call assertions via "$this" everywhere.
    @SvenRtbg
    SvenRtbg committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    25c235f View commit details
    Browse the repository at this point in the history

  2. Fix expected exception message 

    Was never verified using the non-existing second parameter of expectException()
    @SvenRtbg
    SvenRtbg committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    04a25b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Use ::class whenever an instance is checked

    @SvenRtbg
    SvenRtbg committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    ad98b1a View commit details
    Browse the repository at this point in the history