Edge case

cwindolf · Dec 4, 2024 · cc7fc33 · cc7fc33
1 parent ab00f47
commit cc7fc33
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/dartsort/cluster/gaussian_mixture.py b/src/dartsort/cluster/gaussian_mixture.py
@@ -2059,6 +2059,7 @@ def fit(
 
         achans = occupied_chans(features, self.n_channels, neighborhoods=neighborhoods)
         je_suis = achans.numel()
+        do_pca = self.cov_kind == "ppca" and self.ppca_rank
 
         active_mean = active_W = None
         if hasattr(self, "mean"):
@@ -2093,15 +2094,15 @@ def fit(
         if hasattr(self, "W"):
             W_full = self.W
             W_full.fill_(0.0)
-        elif je_suis and res.get("W", None) is not None:
+        elif do_pca:
             W_full = new_zeros((self.noise.rank, self.noise.n_channels, self.ppca_rank))
 
         if je_suis:
             mean_full[:, achans] = res["mu"]
             if res.get("W", None) is not None:
                 W_full[:, achans] = res["W"]
         self.register_buffer("mean", mean_full)
-        if je_suis and res.get("W", None) is not None:
+        if do_pca:
             self.register_buffer("W", W_full)
         nobs = res["nobs"] if je_suis else None
         self.pick_channels(achans, nobs)