-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Package Structure #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation check only for now.
Co-Authored-By: David Mansolino <[email protected]>
Co-Authored-By: David Mansolino <[email protected]>
Co-Authored-By: David Mansolino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks globally very good, just minor cleanups.
Co-Authored-By: David Mansolino <[email protected]>
…botics/epuck_ros2 into refactor-package-structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Description
This aims to improve the structure of the packages, by renaming, deleting unnecessary code and adding proper documentation before it is released:
epuck_ros2_cpp
but it should be language agnostic, so I think it should be renamed toepuck_ros2_driver
epuck_ros2
. That implementation doesn't implement as many features as inepuck_ros2_cpp
and we have much better performances withepuck_ros2_cpp
. To avoid maintaining the code and not to create confusion I think this should be deleted.epuck_ros2
should depend onepuck_ros2_cpp
andepuck_ros2_camera
, and it should provide a mechanism to launch nodes from these packages.Related Issues
Fixes #9
Also, this is related to this PR: cyberbotics/webots_ros2#69
Tasks
epuck_ros2_cpp
toepuck_ros2_driver
epuck_ros2
epuck_ros2
that is able to run nodes fromepuck_ros2_driver
andepuck_ros2_camera
epuck_ros2
does not depends onepuck_ros2_camera
andepuck_ros2_camera
is ignored. This has to be resolved-DAVOID_EPUCK_CAMERA_BUILD
is defined MMAL will be excluded from the build process, otherwise no changes)epuck_ros2_camera
is now part of code quality verification resolve linter errorsAdditional Context
ROS2 installation tutorial will be properly written later with #18.
For organizing documentation I followed this package:
epuck_ros2
in our case) there is no README,Building the packages in development on RPi: