Update windows java dependencies

[devcfgc]

The aim of this PR is to update dependencies and make the module compatible with puppet 4.

• use puppetlabs/download_file module
• use puppet/windows_env module
• allow using windows_java as an entry point of the module instead of using directly the define windows_java:jdk (TODO: in the future will be nice to use a hash/array to allow the installation of different java version packages)
• fix puppet-lint errors/warning
• update documentation

[devcfgc]

@cyberious Would you mind to have a look at this PR, please? I had run the tests locally with ruby version 2.1.10 otherwise I got an error using a lower ruby version:

Gem::InstallError: public_suffix requires Ruby version >= 2.1.                                                                                                                                                                                                                                                               
An error occurred while installing public_suffix (3.0.1), and Bundler cannot continue.                                                                                                                                                                                                                                       
Make sure that `gem install public_suffix -v '3.0.1'` succeeds before bundling.

[cyberious]

Sure, pulling down now to check.

[cyberious]

So for one I am seeing this failure Failed to clone git repository [email protected]:voxpupuli/puppet-download_file.git into spec/fixtures/modules/download_file we may be able to download b/c we have our keys on our machines but travis-ci does not have those ssh keys.

[cyberious]

Also validate_legacy is not support when the puppet version is < 4.0 and as such it is still only a deprecation for validate_bool to be removed

[cyberious]

After further digging I also notice that while I love the move to download_file it actually will cause a hard requirement to drop support for 3.x as it adds the type system. I am fine with this but want to test some other stuff out, should get back to you tomorrow.

[cyberious]

I have been toying with these changes on my branch corresponding to this PR, https://github.com/cyberious/puppet-windows_java/tree/pr12

[devcfgc]

@cyberious thanks for reviewing it, perhaps for the next release you should think about stop supporting puppet 3?? If you need me for anything feel free to ping me =) I'll be on holidays the next 5 days (the family didn't allow me to take my laptop with me 😬 this time) but I'll be glad to help you as soon as I come back