Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serf: Set broadcast timeout to one minute #2100

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

yokaze
Copy link
Contributor

@yokaze yokaze commented Sep 20, 2022

Serf fails to update tags without a longer broadcast timeout in a large cluster.
hashicorp/consul#8435

This PR extends the timeout to one minute.

Signed-off-by: Daichi Sakaue [email protected]

@yokaze yokaze self-assigned this Sep 20, 2022
@yokaze yokaze marked this pull request as ready for review September 20, 2022 12:34
@yokaze yokaze force-pushed the relax-serf-broadcast-timeout branch 2 times, most recently from 1b90487 to f9e48d2 Compare September 21, 2022 03:57
@yokaze yokaze force-pushed the relax-serf-broadcast-timeout branch from f9e48d2 to a6b1323 Compare September 21, 2022 04:00
@yokaze yokaze requested a review from masa213f September 22, 2022 01:03
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yokaze yokaze merged commit 0bc8a79 into main Sep 26, 2022
@yokaze yokaze deleted the relax-serf-broadcast-timeout branch September 26, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants