Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement bpf-map-pressure-exporter #1155

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Implement bpf-map-pressure-exporter #1155

merged 1 commit into from
Dec 4, 2023

Conversation

tkna
Copy link
Contributor

@tkna tkna commented Nov 17, 2023

Signed-off-by: naoki-take [email protected]

@tkna tkna self-assigned this Nov 17, 2023
@tkna tkna requested review from chez-shanpu and terassyi November 17, 2023 01:33
@tkna
Copy link
Contributor Author

tkna commented Nov 17, 2023 •
edited
Loading

Referred to:
https://github.com/cybozu/neco-containers/tree/main/ceph-extra-exporter

@tkna tkna force-pushed the bpf-map-pressure-exporter branch from 1e42bed to f99b90f Compare November 20, 2023 08:52
@tkna
Copy link
Contributor Author

tkna commented Nov 20, 2023 •
edited
Loading

We cannot get the complete map names since they are truncated to 15 characters, so I decided to fetch the pressure of the maps that contain substrings which are specified by mapNames.

@tkna tkna marked this pull request as ready for review November 20, 2023 08:57
chez-shanpu
chez-shanpu reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
I left some comments.

bpf-map-pressure-exporter/README.md Outdated Show resolved Hide resolved
bpf-map-pressure-exporter/src/fetcher.go Outdated Show resolved Hide resolved
bpf-map-pressure-exporter/src/collector.go Outdated Show resolved Hide resolved
bpf-map-pressure-exporter/src/fetcher.go Outdated Show resolved Hide resolved
terassyi
terassyi reviewed Nov 21, 2023
View reviewed changes
bpf-map-pressure-exporter/src/go.mod Outdated Show resolved Hide resolved
bpf-map-pressure-exporter/src/main.go Outdated Show resolved Hide resolved
bpf-map-pressure-exporter/src/fetcher.go Outdated Show resolved Hide resolved
@tkna tkna force-pushed the bpf-map-pressure-exporter branch from e696a0c to 7f125be Compare November 24, 2023 05:23
chez-shanpu
chez-shanpu reviewed Nov 30, 2023
View reviewed changes
bpf-map-pressure-exporter/src/fetcher.go Outdated Show resolved Hide resolved
bpf-map-pressure-exporter/src/main.go Outdated Show resolved Hide resolved
bpf-map-pressure-exporter/src/fetcher.go Outdated Show resolved Hide resolved
@terassyi
Copy link
Contributor

There isn't the configuration to build a container.
We want to build a container image at ghcr.io.

Please add it like below.
https://github.com/cybozu/neco-containers/blob/34f5cc3beafb874b2be4b51decdba0f7abcdb2e8/.github/workflows/main.yaml#L12-L56C25

@tkna tkna force-pushed the bpf-map-pressure-exporter branch 2 times, most recently from af15850 to fd8912d Compare December 1, 2023 07:35
chez-shanpu
chez-shanpu reviewed Dec 1, 2023
View reviewed changes
bpf-map-pressure-exporter/Dockerfile Outdated Show resolved Hide resolved
bpf-map-pressure-exporter/.dockerignore Outdated Show resolved Hide resolved
@tkna tkna force-pushed the bpf-map-pressure-exporter branch 5 times, most recently from a8fbc89 to f389100 Compare December 4, 2023 07:22
@tkna tkna force-pushed the bpf-map-pressure-exporter branch from f389100 to 647db4b Compare December 4, 2023 07:30
terassyi
terassyi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@terassyi terassyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chez-shanpu
chez-shanpu approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@chez-shanpu chez-shanpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkna tkna merged commit 0f2ff6e into main Dec 4, 2023
23 checks passed
@tkna tkna deleted the bpf-map-pressure-exporter branch December 4, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terassyi terassyi terassyi approved these changes

@chez-shanpu chez-shanpu chez-shanpu approved these changes

Assignees

@tkna tkna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkna @terassyi @chez-shanpu