-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend database logger context #165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #165 +/- ##
============================================
+ Coverage 95.23% 95.24% +0.01%
- Complexity 1833 1836 +3
============================================
Files 130 130
Lines 5054 5066 +12
============================================
+ Hits 4813 4825 +12
Misses 241 241 ☔ View full report in Codecov by Sentry. |
lotyp
commented
Mar 21, 2024
msmakouz
requested changes
Mar 26, 2024
Default Value for `$parameters` — The `$parameters` argument now defaults to an empty array ([]). This ensures that it's always iterable, making the function more predictable and eliminating the need for null checks before iterating over $parameters.
roxblnfk
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
msmakouz
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Introduced additional options in DriverConfig for detailed logging control:
logInterpolatedQueries
. Converts query into interpolated one. (Before change, this was done usinglogQueryParameters
)logQueryParameters
- Now, does, what variable name says — Logs query parameters as arrayModified statement method in Driver.php to utilize new logging options, enriching log context with driver details and query parameters.
Rationale
These changes aim to improve the ORM's debugging and monitoring capabilities by offering detailed and configurable logging insights.
Checklist
Added new tests to cover context parameters and driver
Created example application with sample entity, fired persist to get logger output, which now looks like this:
logInterpolatedQueries => true
andlogQueryParameters' => true
:When
logInterpolatedQueries => false
andlogQueryParameters' => true
:Default behavior (both parameters set to
false
):