fix: attribute.uncast([]) (#201)

package.json

@@ -20,6 +20,7 @@
     "test:mysql2": "./test/start.sh test/integration/mysql2.test.js",
     "test:postgres": "./test/start.sh test/integration/postgres.test.js",
     "test:sqlite": "./test/start.sh test/integration/sqlite.test.js",
+    "test:sqlcipher": "./test/start.sh test/integration/sqlcipher.test.js",
     "test:dts": "./test/start.sh test/types/dts.test.js",
     "test:coverage": "nyc ./test/start.sh && nyc report --reporter=lcov",
     "lint": "eslint ./",

src/drivers/abstract/attribute.js

@@ -127,7 +127,9 @@ class Attribute {
   }
 
   uncast(value) {
-    if (Array.isArray(value)) return value.map(entry => this.type.uncast(entry));
+    if (Array.isArray(value) && this.jsType !== JSON) {
+      return value.map(entry => this.type.uncast(entry));
+    }
     return this.type.uncast(value);
   }
 }

src/realm.js

@@ -130,8 +130,11 @@ class Realm {
       models = Object.values(this.models);
     }
 
+    // models could be connected already if cached
+    models = models.filter(model => !model.synchronized);
+
     if (models.length > 0) {
-      await loadModels(this.Bone, models.filter(model => !model.synchronized), this.options);
+      await loadModels(this.Bone, models, this.options);
     }
     this.connected = true;
     return this.Bone;

test/integration/sqlcipher.test.js

@@ -14,14 +14,17 @@ before(async function() {
   const database = new Database(plaintext, OPEN_READWRITE | OPEN_CREATE);
   await fs.unlink(encrypted).catch(() => {/* ignored */});
   // https://discuss.zetetic.net/t/how-to-encrypt-a-plaintext-sqlite-database-to-use-sqlcipher-and-avoid-file-is-encrypted-or-is-not-a-database-errors/868
-  await new Promise((resolve, reject) => {
-    database.serialize(function() {
-      database.run(`ATTACH DATABASE '${encrypted}' AS encrypted KEY 'Accio!'`);
-      database.run(`SELECT sqlcipher_export('encrypted')`);
-      database.run(`DETACH DATABASE encrypted`, function(err) {
-        if (err) reject(err);
-        resolve();
-      });
+
+  database.serialize(function() {
+    database.run(`ATTACH DATABASE '${encrypted}' AS encrypted KEY 'Accio!'`);
+    database.run(`SELECT sqlcipher_export('encrypted')`);
+    database.run(`DETACH DATABASE encrypted`);
+  });
+
+  await new Promise(function(resolve, reject) {
+    database.close(function(err) {
+      if (err) reject(err);
+      else resolve();
     });
   });
 

test/integration/suite/data_types.test.js

@@ -18,6 +18,7 @@ describe('=> Data types', () => {
       publishedAt: DATE(6),
     }
   };
+
   before(async () => {
     await Note.driver.dropTable('notes');
     await Note.sync();
@@ -79,15 +80,15 @@ describe('=> Data types - JSON', () => {
   }
 
   beforeEach(async () => {
+    Object.defineProperties(Note, {
+      columns: { value: [], configurable: true },
+      synchronized: { value: undefined, configurable: true }
+    });
     await Note.driver.dropTable('notes');
-  });
-
-  afterEach(async () => {
-    await Note.driver.dropTable('notes');
+    await Note.sync();
   });
 
   it('=> init', async () => {
-    await Note.sync();
     await Note.create({ title: 'Leah',  meta: { foo: 1, baz: 'baz' }, metab: { foo: 2, baz: 'baz1' } });
     const foundNote = await Note.first;
     const { meta, metab } = Note.attributes;
@@ -104,6 +105,11 @@ describe('=> Data types - JSON', () => {
     assert.deepEqual(foundNote.meta, { foo: 1, baz: 'baz' });
     assert.deepEqual(foundNote.metab, { foo: 2, baz: 'baz1' });
   });
+
+  it('=> type casting', async function() {
+    await Note.create({ meta: {} });
+    await Note.create({ meta: [] });
+  });
 });
 
 
@@ -132,11 +138,11 @@ describe('=> Data types - BINARY', () => {
   });
 
   beforeEach(async () => {
-    (Note && await Note.driver.dropTable('notes'));
+    if (Note) await Note.driver.dropTable('notes');
   });
 
   afterEach(async () => {
-    (Note && await Note.driver.dropTable('notes'));
+    if (Note) await Note.driver.dropTable('notes');
   });
 
   it('=> init', async () => {

test/unit/realm.test.js

@@ -875,6 +875,16 @@ describe('=> Realm', () => {
       });
       await realm.connect();
 
+      await assert.doesNotReject(async function() {
+        const realm2 = new Realm({
+          port: process.env.MYSQL_PORT,
+          user: 'root',
+          database: 'leoric',
+          models: [ User ],
+        });
+        await realm2.connect();
+      });
+
       class Post extends Bone {
         static table = 'articles'
       }