fix: sequelize set datavalue should not check attribute strictly (#114)

cyjake · Jun 11, 2021 · 85b3ab9 · 85b3ab9
1 parent fb12f19
commit 85b3ab9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/adapters/sequelize.js b/lib/adapters/sequelize.js
@@ -644,7 +644,8 @@ module.exports = Bone => {
     }
 
     setDataValue(key, value) {
-      this.attribute(key, value);
+      if (this.hasAttribute(key)) this.attribute(key, value);
+      else this[key] = value;
     }
 
     // EXISTS

diff --git a/test/unit/adapters/sequelize.test.js b/test/unit/adapters/sequelize.test.js
@@ -873,6 +873,14 @@ describe('=> Sequelize adapter', () => {
     const extra = post.getDataValue('extra');
     assert(!extra);
   });
+
+  it('instance.setDataValue', async () => {
+    const book = await Book.create({ name: 'Book of Tyrael', price: 20 });
+    book.setDataValue('name', 'Book1');
+    assert(book.name === 'Book1');
+    book.setDataValue('hello', 'hello');
+    assert(book.hello === 'hello');
+  });
 });
 
 describe('Model scope', () => {