Do not allow plugins to act on global.cylc #5839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.do_not_allow_plugins_acting_on_global.cylc
branch
from
5332e80 to
e488705
Compare
wxtim
commented
Nov 23, 2023
MetRonnie
reviewed
Nov 27, 2023
|
Flake8 failing on unused import |
Co-authored-by: Ronnie Dutta <[email protected]>
oliver-sanders
approved these changes
Dec 4, 2023
wxtim
commented
Dec 4, 2023
|
Kicking tests |
|
(some mypy issues) |
wxtim
force-pushed
the
fix.do_not_allow_plugins_acting_on_global.cylc
branch
from
074c719 to
6b99618
Compare
8 tasks
MetRonnie
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugins should not be called when parsing global.cylc. This can become problematic if the plugin wants to access the global config.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.