tests/i: fix flaky tui/test_updater tests #5849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* These tests were trying to be a bit too clever, testing the updater whilst it was running. * This wasn't really needed for what the tests were tring to assert, there are other tests which run Tui for real (live updater and all), those tests didn't exist when these ones were written. * This commit freezes the updater so we can run it in lock-step with the tests.
|
Well, it go rid of the test_updater failures, will follow up on the others later... |
MetRonnie
approved these changes
Nov 29, 2023
7 tasks
8 tasks
wxtim
approved these changes
Nov 30, 2023
|
@wxtim - got the remaining tests fixed in the next PR |
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Dec 5, 2023
…at_runtime * upstream/master: tui: avoid deprecated import (cylc#5858) Exclude broken pytest-asyncio version remove lint (cylc#5856) Async pipe decorator: preserve wrapped func signature Maintain order for CYLC_PYTHONPATH (cylc#5853) Update tests/integration/tui/conftest.py tests/i: fix flaky tui/test_updater tests (cylc#5849) tests/i: tui - attempt to stabilise tests Bump pypa/gh-action-pypi-publish from 1.8.10 to 1.8.11 (cylc#5851) tests/i: fix flaky tui/test_updater tests Improve changelog entries Fix bad TOML example in `cylc lint` docstring (cylc#5843) lint - S011 no longer warns against 0{{a}} (cylc#5841) `cylc lint`: add rule to catch `rose date` tui: show view tui: log view tui: tidy dangling interfaces tui: fix an obscure freezing issue tui: update screenshots Tui 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests tests passed on the PR (#5731), but failed when the PR was merged into master, three weeks later. I'm not sure what changed between these points, but they appear to be stable now.
Try me:
while true; do if ! pytest tests/integration/tui/test_updater.py::test_filters -s; then break; fi; doneCheck List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.