Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests.move deprecations tests to integration battery #5901

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 2, 2024

Testing only - a couple of easy wins I spotted moving functional tests to the integration battery. Will clash with #5874

@wxtim wxtim requested a review from oliver-sanders January 2, 2024 15:55
@wxtim wxtim marked this pull request as draft January 2, 2024 15:55
@wxtim wxtim self-assigned this Jan 9, 2024
@wxtim wxtim marked this pull request as ready for review January 9, 2024 15:49
@wxtim wxtim requested a review from markgrahamdawson January 9, 2024 15:49
@wxtim wxtim added the could be better Not exactly a bug, but not ideal. label Jan 9, 2024
@wxtim wxtim added this to the cylc-8.3.0 milestone Jan 9, 2024
pytest.ini Outdated Show resolved Hide resolved
tests/integration/scripts/test_validate_integration.py Outdated Show resolved Hide resolved
tests/integration/scripts/test_validate_integration.py Outdated Show resolved Hide resolved
tests/integration/scripts/test_validate_integration.py Outdated Show resolved Hide resolved
@wxtim wxtim requested a review from oliver-sanders January 12, 2024 15:21
oliver-sanders
oliver-sanders previously approved these changes Jan 12, 2024
@oliver-sanders oliver-sanders removed the request for review from markgrahamdawson January 12, 2024 15:33
@oliver-sanders oliver-sanders dismissed their stale review January 12, 2024 15:34

test fails :(

@wxtim wxtim requested a review from oliver-sanders January 15, 2024 08:32
@wxtim wxtim force-pushed the tests.move_deprecations_tests_to_integration_battery branch from 74b9e7c to 53cfeb7 Compare January 15, 2024 08:32
@wxtim wxtim requested a review from oliver-sanders January 16, 2024 08:45
@oliver-sanders oliver-sanders merged commit 6cec298 into cylc:master Jan 16, 2024
25 checks passed
@wxtim wxtim deleted the tests.move_deprecations_tests_to_integration_battery branch January 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants