Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pbs: update connection failed error message #6569

Merged
merged 1 commit into from
Jan 28, 2025
Merged

pbs: update connection failed error message #6569

merged 1 commit into from
Jan 28, 2025
+5 −1

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jan 22, 2025 •
edited
Loading

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

Sorry, something went wrong.

@oliver-sanders oliver-sanders added bug Something is wrong :( small labels Jan 22, 2025
@oliver-sanders oliver-sanders added this to the 7.8.x milestone Jan 22, 2025
@oliver-sanders oliver-sanders self-assigned this Jan 22, 2025
@oliver-sanders
pbs: update connection failed error message
7b6d8cb 
* Addresses cylc#6531 on the 7.8.x branch.
* Update the PBS job runner to reflect a change in error message.
* The new pattern will also match the old format.
wxtim
wxtim approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable - I presume that it may be tricky to test?

@oliver-sanders
Copy link
Member Author

@hjoliver, could you once-over this one.

This in combination with #6541 should go into the final-final-final-final-final-final Cylc 7 release!

@wxtim wxtim linked an issue Jan 23, 2025 that may be closed by this pull request
PBS: detection of qstat failures no longer working #6531
Closed
@hjoliver hjoliver merged commit 6353ff6 into cylc:7.8.x Jan 28, 2025
@hjoliver hjoliver modified the milestones: 7.8.x, 7.9.10 and 7.8.15 Jan 28, 2025
@oliver-sanders oliver-sanders deleted the 6531.cylc-7 branch January 28, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver

@wxtim wxtim

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
7.9.10 and 7.8.15
Development

Successfully merging this pull request may close these issues.

PBS: detection of qstat failures no longer working
3 participants
@oliver-sanders @hjoliver @wxtim