Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc set: set success pathway outputs if none specified and no required outputs #6570

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jan 22, 2025

Supersedes #6505

R1 = a? => b
$ cylc set workflow//1/a

does nothing and currently produces no warning.

Make it emit the success pathway outputs, kind of like how skip mode works, which would be a:succeeded in this case.

https://cylc.discourse.group/t/cylc-set-for-a-task-with-multiple-outputs-doesnt-seem-to-do-anything/1074

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added small could be better Not exactly a bug, but not ideal. labels Jan 22, 2025
@MetRonnie MetRonnie added this to the 8.5.0 milestone Jan 22, 2025
@MetRonnie MetRonnie self-assigned this Jan 22, 2025
@wxtim
Copy link
Member

wxtim commented Jan 22, 2025

Why not use cylc set workflow//1/a --out skip.

@MetRonnie
Copy link
Member Author

This is to make the default behaviour of cylc set more sensible

@@ -27,6 +27,7 @@ addopts = --verbose
# disable pytest-tornasync because it conflicts with pytest-asyncio's auto mode
-p no:tornado
-m "not linkcheck"
verbosity_assertions = 2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This makes pytest show full diffs without all the extra junk that comes from running with -vv. I find the truncated diffs that pytest shows by default to be difficult to understand.)

@oliver-sanders
Copy link
Member

LGTM, needs some docs in cylc set --help and the set mutation in the GraphQL schema.

@oliver-sanders oliver-sanders removed the request for review from hjoliver January 28, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants