use fqdn in rose-stem tests #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
approved these changes
Feb 5, 2024
MetRonnie
approved these changes
Feb 5, 2024
wxtim
added a commit
that referenced
this pull request
May 2, 2024
* upstream/master: (47 commits) simplify rose stem tests (#314) Apply suggestions from code review add developer docs build(deps): bump pypa/gh-action-pypi-publish from 1.8.11 to 1.8.14 (#301) [skip ci] tests: remove defunct cli wrappers (#297) tests/functional: fix scoping issues setup: add missing pytest-asyncio test dependency install/reinstall: adapt to new async interfaces tests: fix flaky text fileinstall: remove asyncio logic Bump codecov/codecov-action from 3 to 4 (#295) use fqdn in rose-stem tests (#294) Update setup.cfg setup: bump rose version fix merge mistake fix flake8 fixed a test Apply suggestions from code review Bump actions/setup-python from 4 to 5 (#280) Update tests/functional/test_utils.py ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failed (locally) due to a local change in config. On looking into the breakage I realized that we only wanted to test that the hostname as Rose finds it is inserted into the config. We aren't trying to check the rose localhost getting method in this test.
Tests related to #276 are still failing, but should pass once that PR and it's companions are merged.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.