Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Empy Support #353

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Remove Empy Support #353

merged 7 commits into from
Nov 28, 2024

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Nov 20, 2024

Cylc will no longer support Empy from 8.4.0. This commit removes empy functionality and tests from Cylc Rose.

Follow on from cylc/cylc-flow#6476

n.b. Functional Changes in bcf1629. Other commit should just be styling things.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim added the refactor label Nov 20, 2024
@wxtim wxtim requested a review from oliver-sanders November 20, 2024 13:42
@wxtim wxtim self-assigned this Nov 20, 2024
@wxtim wxtim added this to the 1.5.0 milestone Nov 20, 2024
cylc/rose/__init__.py Outdated Show resolved Hide resolved
@@ -38,7 +38,7 @@ jobs:
uses: cylc/release-actions/install-cylc-components@v1
with:
cylc_flow: true
cylc_flow_opts: 'empy'
cylc_flow_opts: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I look for this cylc_flow_opts variable in cylc-rose code it only exists in the yaml file. Is it needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an argument to the cylc-release-actions action. On looking, it's not required, so is probably unecessary. Will try removal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is 'all' (equivalent to pip install cylc-flow[all]) which is unnecessary for these tests, leaving it as '' (as you have done) is the correct thing to do.

@wxtim wxtim merged commit 1100801 into cylc:master Nov 28, 2024
8 of 9 checks passed
@wxtim wxtim deleted the remove.empy branch November 28, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants