-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Empy Support #353
Remove Empy Support #353
Conversation
empy functionality and tests from Cylc Rose.
@@ -38,7 +38,7 @@ jobs: | |||
uses: cylc/release-actions/install-cylc-components@v1 | |||
with: | |||
cylc_flow: true | |||
cylc_flow_opts: 'empy' | |||
cylc_flow_opts: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I look for this cylc_flow_opts
variable in cylc-rose code it only exists in the yaml file. Is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an argument to the cylc-release-actions action. On looking, it's not required, so is probably unecessary. Will try removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is 'all'
(equivalent to pip install cylc-flow[all]
) which is unnecessary for these tests, leaving it as ''
(as you have done) is the correct thing to do.
Co-authored-by: Mark Dawson <[email protected]>
Cylc will no longer support Empy from 8.4.0. This commit removes empy functionality and tests from Cylc Rose.
Follow on from cylc/cylc-flow#6476
n.b. Functional Changes in bcf1629. Other commit should just be styling things.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).?.?.x
branch.