Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering by waiting tasks in GScan doesn't work #1537

Closed
MetRonnie opened this issue Oct 31, 2023 · 3 comments · Fixed by #1549
Closed

Filtering by waiting tasks in GScan doesn't work #1537

MetRonnie opened this issue Oct 31, 2023 · 3 comments · Fixed by #1549
Labels
bug Something isn't working
Milestone

Comments

@MetRonnie
Copy link
Member

No workflows show when filtering by waiting tasks, even though there are waiting tasks. This bug affects the offline mode and the production build

image

@MetRonnie MetRonnie added the bug Something isn't working label Oct 31, 2023
@MetRonnie MetRonnie added this to the 2.x milestone Oct 31, 2023
@MetRonnie MetRonnie modified the milestones: 2.x, 2.2.1 Nov 13, 2023
@oliver-sanders
Copy link
Member

oliver-sanders commented Nov 22, 2023

This will never work because the state totals are actually listing job states not task states.

The "waiting" state should not be an option for filtering workflows. The same applies to preparing if it too is an option.

@MetRonnie
Copy link
Member Author

MetRonnie commented Nov 22, 2023

In #1549 I corrected the list of the states GScan was comparing against from jobs -> tasks

@oliver-sanders
Copy link
Member

Apologies, state-totals are task states, mb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants