Fix GScan bug when filtering hierarchical workflows by state #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid processing nodes unnecessarily
The following states were not being matched: waiting, preparing, expired
Avoid deep clone during filtering by using a WeakMap to store the filtered-out state of each node in the tree
MetRonnie
force-pushed
the
gscan-filter
branch
from
5c04c9a to
9eb8da0
Compare
MetRonnie
commented
Nov 16, 2023
|
Bumping efficiency issues to #1555 |
oliver-sanders
approved these changes
Nov 21, 2023
wxtim
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1416 which introduced a bug where filtering by workflow state would show all workflows in hierarchies that had a match, instead of only the matching workflows:
Also closes #1537 which was unrelated to #1416
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.CHANGES.mdentry included if this is a change that can affect users