Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: Cypress test on Windows Edge and Mac WebKit #1649

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,11 @@ jobs:
matrix:
browser: [firefox, chrome, electron]
os: [ubuntu-latest]
# TODO: re-enable once macos build is stable #590
# include:
# - os: macos-latest
# browser: edge
include:
- os: macos-latest
browser: webkit
- os: windows-latest
browser: edge
env:
COVERAGE: true
steps:
Expand All @@ -83,6 +84,10 @@ jobs:
node-version: 'lts/*'
cache: yarn

- name: Install WebKit support
if: matrix.browser == 'webkit'
run: yarn add playwright-webkit --dev --mode=update-lockfile

- name: Test (E2E)
uses: cypress-io/github-action@v6
env:
Expand All @@ -95,10 +100,14 @@ jobs:
browser: ${{ matrix.browser }}

- name: Test (component)
# Component tests on webkit hang for some reason
if: matrix.browser != 'webkit'
uses: cypress-io/github-action@v6
with:
component: true
browser: ${{ matrix.browser }}
# already installed in E2E step
install: false

- name: Upload screenshots
uses: actions/upload-artifact@v4
Expand Down
1 change: 1 addition & 0 deletions cypress.config.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,5 @@ module.exports = defineConfig({
},

morgan: false, // Disable XHR logging as it's very noisy
experimentalWebKitSupport: true,
})
2 changes: 1 addition & 1 deletion tests/e2e/specs/userprofile.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ describe('User Profile', () => {
.get('.node-data-cycle')
.then(($els) => {
expect(
Array.from($els, (el) => el.innerText)
Array.from($els, (el) => el.innerText.trim())
).to.deep.equal(expected)
})
}
Expand Down
Loading