Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of cycle points that don't have children in tree view #2055

Closed
wants to merge 3 commits into from

Conversation

MetRonnie
Copy link
Member

Partially addresses #1999 by fixing the display, but does not fix the cause of the issue.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are not needed
  • Changelog entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added bug Something isn't working small labels Jan 31, 2025
@MetRonnie MetRonnie added this to the 2.8.0 milestone Jan 31, 2025
@MetRonnie MetRonnie self-assigned this Jan 31, 2025
@oliver-sanders
Copy link
Member

oliver-sanders commented Jan 31, 2025

This isn't a display issue, it's a problem with the data in the UI store and a memory leak. We should fix the issue rather than trying to cover it over in this way.

@MetRonnie
Copy link
Member Author

This is not covering anything up, it's just aiming to fix the display aspect of the issue. However I've realised it still leaves the expand/collapse button visible and it would be tricky to include that, so I'll just pull out the tidying into a new PR

@MetRonnie MetRonnie closed this Jan 31, 2025
@MetRonnie MetRonnie deleted the treeitem branch January 31, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants