New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve cat-log test failure debuggability #527

Merged

oliver-sanders merged 1 commit into cylc:1.4.x from MetRonnie:actions

Nov 23, 2023

Member

MetRonnie commented Nov 22, 2023

Check List

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
Tests
No changelog needed
No docs needed
If this is a bug fix, PR should be raised against the relevant ?.?.x branch.


          Improve cat-log test failure debuggability

7ff3c16

MetRonnie added the small label

MetRonnie added this to the 1.4.2 milestone

MetRonnie requested a review from oliver-sanders

November 22, 2023 13:51

MetRonnie self-assigned this

Member Author

MetRonnie commented Nov 22, 2023

MacOS failed here and the socket.gaierror is surfaced now: https://github.com/cylc/cylc-uiserver/actions/runs/6958237661/job/18932795134?pr=527#step:10:109

oliver-sanders approved these changes

View reviewed changes

oliver-sanders merged commit 8a547f4 into cylc:1.4.x

4 of 5 checks passed

MetRonnie deleted the actions branch

November 23, 2023 12:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels