Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc play service: don't unset $CYLC_ENV_NAME if no version specified #533

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Dec 1, 2023

Follow-up to #525

Unfortunately it broke job submission cylc play if you were using a non-standard Cylc environment name (i.e. not cylc-8.X.Y) Cylc environment name that didn't match cylc-8.X.Y exactly, and didn't specify a version in the cylc play-edit form

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added bug Something isn't working small labels Dec 1, 2023
@MetRonnie MetRonnie self-assigned this Dec 1, 2023
@MetRonnie MetRonnie added this to the 1.4.3 milestone Dec 1, 2023
@MetRonnie MetRonnie changed the base branch from master to 1.4.x December 1, 2023 12:39
@dpmatthews
Copy link
Contributor

a non-standard Cylc environment name (i.e. not cylc-8.X.Y)

The naming convention recommended in the wrapper script is cylc-8.X.Y-Z so this doesn't just affect non-standard names

changes.d/533.fix.md Outdated Show resolved Hide resolved
@MetRonnie MetRonnie merged commit f671d5c into cylc:1.4.x Dec 5, 2023
@MetRonnie MetRonnie deleted the play-service branch December 5, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants