-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cat-log: add timeout to processes #645
Conversation
(gah, the trouble orphaned cat-log processes have caused over the years!) |
* Partially addresses cylc#643 * Add a timeout to `cylc cat-log` processes: * Ensures we don't accumulate them by accident. * Improves efficiency by closing long-lived log streams (the user probably isn't looking at the log file any more and the log file has probably stopped growing anyway). * At present, `cylc cat-log` processes may be left behind if the websocket is closed abruptly. This has been observed as the result of a proxy timeout.
Co-authored-by: Tim Pillinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasonable. Thank you for all the extra annotation. Some of this code is NOT self documenting IMO.
One Spelling error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, good.
cylc cat-log
processes:cylc cat-log
processes may be left behind if the websocket is closed abruptly. This has been observed as the result of a proxy timeout.Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).?.?.x
branch.