Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline data: enable querying failed jobs #657

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jan 9, 2025

(POC PR to unblock upstream work, I'm not assigned, feel free to take over)

  • Allow job queries to be performed on jobs which have failed or have not run.
  • Implemented the ids, exids, states, exstates fields for offline job queries (partially addresses offline data: support arguments in task query #440).
  • Fix the state field which previously returned submit_status.

Example query:

query {
  jobs(live: false, workflows: ["*"], ids: ["*/foo"]) {
    id
    state
  }
}

Notes:

  • The analysis view will need to be updated to use the states argument to filter for succeeded tasks (previously this was implied).
  • If there are any queries that use the state field, these will need to be updated now that it returns the job state rather than the run_status.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Allow job queries to be performed on jobs which have failed or have
  not run.
* Added a `run_status` field to allow queries to filter in this way, the
  Gantt view will need to be updated to match this.
* Fix the `state` field which previously returned `submit_status`.
.
@markgrahamdawson markgrahamdawson self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants