Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-cylc-components: respect login shell #100

Open
wants to merge 5 commits into
base: v1
Choose a base branch
from

Conversation

oliver-sanders
Copy link
Member

Use a Bash login shell.

This opens up working with Micromamba managed environments.

Checklist

  • I have read the contributing instructions in README.md and have opened this against the correct branch & milestone

Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will give this a try with the downstream PRs.

Test: oliver-sanders/cylc-rose#5

Copy link
Member Author

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. The action is running fine, but errors are appearing downstream (which doesn't make sense).

Can see some set -u error coming from profile.d stuff (which we have no control over), will try without 🤷 .

That seems to have worked: https://github.com/oliver-sanders/cylc-rose/actions/runs/13674608714/job/38232630689?pr=5

@oliver-sanders oliver-sanders requested a review from MetRonnie March 5, 2025 11:18
@oliver-sanders oliver-sanders marked this pull request as ready for review March 5, 2025 11:18
@MetRonnie
Copy link
Member

MetRonnie commented Mar 5, 2025

Actually would it be worth adding a test for this to?

name: Test
# Limited unit testing of the actions

@oliver-sanders
Copy link
Member Author

@MetRonnie, added a simple test.

@oliver-sanders oliver-sanders self-assigned this Mar 6, 2025
Comment on lines 167 to 170
- name: setup python
uses: actions/setup-python@v5
with:
python-version: '3.10'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, to clarify I meant testing with setup-micromamba, although testing with both in a matrix might be good.

Copy link
Member Author

@oliver-sanders oliver-sanders Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants