-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install-cylc-components: respect login shell #100
base: v1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use bash -elo pipefail {0}
? https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#defaultsrunshell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will give this a try with the downstream PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. The action is running fine, but errors are appearing downstream (which doesn't make sense).
Can see some set -u
error coming from profile.d
stuff (which we have no control over), will try without 🤷 .
That seems to have worked: https://github.com/oliver-sanders/cylc-rose/actions/runs/13674608714/job/38232630689?pr=5
Actually would it be worth adding a test for this to? release-actions/.github/workflows/test.yml Lines 1 to 3 in 04781c7
|
4c24efe
to
d79bb6c
Compare
d79bb6c
to
2f16a6c
Compare
@MetRonnie, added a simple test. |
.github/workflows/test.yml
Outdated
- name: setup python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, to clarify I meant testing with setup-micromamba
, although testing with both in a matrix might be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
a85bdfb
to
8891060
Compare
Use a Bash login shell.
This opens up working with Micromamba managed environments.
Checklist
README.md
and have opened this against the correct branch & milestone