Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cleanup
Browse files Browse the repository at this point in the history
krlmlr committed Oct 30, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent ea2bf61 commit 80a6335
Showing 6 changed files with 0 additions and 18 deletions.
3 changes: 0 additions & 3 deletions tests/testthat/test-duckdb.R
Original file line number Diff line number Diff line change
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
# Need skip in every test block, unfortunately
skip_if_src_not("duckdb")

# https://github.com/tidyverse/dbplyr/pull/1190
skip_if(is(my_test_con(), "MySQLConnection") && packageVersion("dbplyr") < "2.4.0")

expect_snapshot({
dm_for_filter_df() %>%
dm_sql(my_test_con())
3 changes: 0 additions & 3 deletions tests/testthat/test-maria.R
Original file line number Diff line number Diff line change
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
# Need skip in every test block, unfortunately
skip_if_src_not("maria")

# https://github.com/tidyverse/dbplyr/pull/1190
skip_if(is(my_test_con(), "MySQLConnection") && packageVersion("dbplyr") < "2.4.0")

expect_snapshot({
dm_for_filter_df() %>%
dm_sql(my_test_con())
3 changes: 0 additions & 3 deletions tests/testthat/test-mssql.R
Original file line number Diff line number Diff line change
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
# Need skip in every test block, unfortunately
skip_if_src_not("mssql")

# https://github.com/tidyverse/dbplyr/pull/1190
skip_if(is(my_test_con(), "MySQLConnection") && packageVersion("dbplyr") < "2.4.0")

expect_snapshot({
dm_for_filter_df() %>%
dm_sql(my_test_con())
3 changes: 0 additions & 3 deletions tests/testthat/test-mysql.R
Original file line number Diff line number Diff line change
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
# Need skip in every test block, unfortunately
skip_if_src_not("mysql")

# https://github.com/tidyverse/dbplyr/pull/1190
skip_if(is(my_test_con(), "MySQLConnection") && packageVersion("dbplyr") < "2.4.0")

expect_snapshot({
dm_for_filter_df() %>%
dm_sql(my_test_con())
3 changes: 0 additions & 3 deletions tests/testthat/test-postgres.R
Original file line number Diff line number Diff line change
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
# Need skip in every test block, unfortunately
skip_if_src_not("postgres")

# https://github.com/tidyverse/dbplyr/pull/1190
skip_if(is(my_test_con(), "MySQLConnection") && packageVersion("dbplyr") < "2.4.0")

expect_snapshot({
dm_for_filter_df() %>%
dm_sql(my_test_con())
3 changes: 0 additions & 3 deletions tests/testthat/test-sqlite.R
Original file line number Diff line number Diff line change
@@ -8,9 +8,6 @@ test_that("dm_sql()", {
# Need skip in every test block, unfortunately
skip_if_src_not("sqlite")

# https://github.com/tidyverse/dbplyr/pull/1190
skip_if(is(my_test_con(), "MySQLConnection") && packageVersion("dbplyr") < "2.4.0")

expect_snapshot({
dm_for_filter_df() %>%
dm_sql(my_test_con())

0 comments on commit 80a6335

Please sign in to comment.