Correct pagination while displaying contacts #1125
Open
+96
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an other issue reported by @Baraka24 and which concerns this PR. |
Shadow243
force-pushed
the
correct-contact-group
branch
2 times, most recently
from
64d315d
to
5514731
Compare
Shadow243
force-pushed
the
correct-contact-group
branch
3 times, most recently
from
5d777af
to
06779dd
Compare
Shadow243
force-pushed
the
correct-contact-group
branch
from
06779dd
to
ef2cf80
Compare
kroky
reviewed
Aug 5, 2024
| } elseif (is_object($value)) { | ||
| $reflection = new ReflectionClass($value); | ||
| $property = $reflection->getProperty('data'); | ||
| $property->setAccessible(true); // Make the private property accessible |
There was a problem hiding this comment.
There is a reason why private properties are private and using reflection to bypass this is something nasty. If this is a contact object isn't $value->value($_key) enough to get you what you want?
kroky
reviewed
Aug 5, 2024
| } | ||
|
|
||
| public function group_by($column = 'group') { |
There was a problem hiding this comment.
Can you refactor the code to group by a string version of the column name? I don't see a reason we group by a callable or support cases for array or object contacts. You can refactor calling code to ensure we are working with a standard set of data - either array of arrays or array of contact objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paging affects groups.
Ex: if in trusted Contacts there are 100 contacts and in Collected Contacts we have 2 contacts, the pagination will ensure that the 2 contacts in Collected are not displayed.
In this PR we group first then we paginate what is already grouped