-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add TypeScript definition to task.js #544
Conversation
Sorry to ping directly @lmiller1990 and @cacieprins but since you reviewed the last PR and this PR also has not been reviewed in >1 year, please give it a look. This TypeScript incompatibility blocks all validation of Cypress code coverage (which is important when combining multiple plugins) and linters that prevent the use of |
@CharlesStover this is no longer an issue in Cypress 10+ AFAIK. Can you provide an example of this in a newer version of Cypress? |
Still an error @jordanpowell88 Let's approve and merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, sorry to keep you waiting for a year
Please ping me if you need 👀 on anything
🎉 This PR is included in version 3.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I added another PR tangential to this issue, as I don't think the type is 100% correct. |
Fixes error in IDE:
Fixes error in CI:
Workaround
I've been copy-pasting this between repos, which is a poor developer experience, but it's also now not working in monorepos, because it's existence in the root directory is not picked up by the workspace-specific linter.
The aim of this PR is to apply the workaround solution to this repository such that the workaround is no longer required.