fix: improve performance combining coverage on large codebases #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
koenvangeert
force-pushed
the
koenvg/combineCoverage-performance
branch
from
8784890
to
2cb325c
Compare
|
@koenvangeert Could you sign our CLA? |
|
@jennifer-shehane Can I do anything else to help this move forward? |
jennifer-shehane
changed the title
koenvangeert
force-pushed
the
koenvg/combineCoverage-performance
branch
from
2cb325c
to
279dd87
Compare
koenvangeert
force-pushed
the
koenvg/combineCoverage-performance
branch
from
279dd87
to
def56ac
Compare
|
🎉 This PR is included in version 3.13.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the constant reading and writing of the coverage object to disk for each test.
Keep it in memory and then write it once after each suite to get the correct report out.
We can optimise further by only writing to disk after all suites are done but the performance gains for this are a lot less.
Some measurements from the codebase I'm testing this on.
Before the change:
combineCoverage: 855.495ms
After:
combineCoverage: 295.321ms