Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support firefox 135 and above with xz compression #1295

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Feb 5, 2025

Issue

Firefox 135.0 announced that "Linux binaries are now provided in XZ format, replacing the previous BZ2 format, offering faster unpacking and smaller file sizes."

The change is not compatible with the current factory/installScripts/firefox/default.sh which assumes a bz2 extension for the Firefox download file. Attempting to configure Firefox 135.0 therefore fails.

Change

For Firefox 134 and below use bz2
For Firefox 135 and above use xz

change to tar -xaf for automatic recognition of compression type.

Verification

cd factory
docker compose build factory
export FIREFOX_VERSION='134.0'
docker compose build firefox
export FIREFOX_VERSION='135.0'
docker compose build firefox

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 self-assigned this Feb 5, 2025
@MikeMcC399 MikeMcC399 force-pushed the support-firefox-xz branch 4 times, most recently from 4a1f969 to d91e8f6 Compare February 5, 2025 12:06
@MikeMcC399 MikeMcC399 marked this pull request as ready for review February 5, 2025 12:16
@MikeMcC399
Copy link
Collaborator Author

MikeMcC399 commented Feb 5, 2025

Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MikeMcC399 ! I am working on the Cypress 14.0.2 release today and am going to merge this in and make Firefox 135 the default in the factory with the 14.0.2 version bump in the factory

@AtofStryker AtofStryker merged commit 4af0cc5 into cypress-io:master Feb 5, 2025
42 checks passed
@MikeMcC399
Copy link
Collaborator Author

@AtofStryker

Thank you @MikeMcC399 ! I am working on the Cypress 14.0.2 release today and am going to merge this in and make Firefox 135 the default in the factory with the 14.0.2 version bump in the factory

Very good! I only noticed after I submitted this PR that Cypress 14.0.2 is pending, so it looks like it came just in time for you 🙂 !

@MikeMcC399 MikeMcC399 deleted the support-firefox-xz branch February 5, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Firefox 135.0 and above
3 participants