changes of visibility in documentation #5867
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
|
|
|
MikeMcC399
reviewed
Jul 12, 2024
MikeMcC399
reviewed
Jul 12, 2024
Comment on lines
86
to
98
| ### Visibility | ||
|
|
||
| :::tip | ||
|
|
||
| Most of the time you should check if element is not hidden. Some elements might be visible but not clickable or interactable. | ||
|
|
||
| Cypress check visibility like browsers [checkVisibility](https://developer.mozilla.org/en-US/docs/Web/API/Element/checkVisibility). | ||
| There are some exceptions from browser checks: | ||
| - in `option` inside `select` visibility is determined by visibility of parent `select` element | ||
| - if element is offscreen it is consided invisible | ||
| - if parent cover element it is consided invisible | ||
| In old browsers that not support [checkVisibility] check is hidden is performed. | ||
|
|
There was a problem hiding this comment.
There are some grammatical and spelling errors in this section.
There was a problem hiding this comment.
I didn't comment in more detail because this PR is still in draft state.
MikeMcC399
reviewed
Jul 12, 2024
Co-authored-by: Mike McCready <[email protected]>
Co-authored-by: Mike McCready <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in cypress-io/cypress#29741 now updated in documentation.
This is still early so it should be done after this pull request date and version will be finally known.