-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add yarn 1 (classic) examples #828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All manual tests pass. I will follow up this PR with a Yarn Modern example PR. It is already prepared and needs this Yarn 1 (Classic) PR merging first. (See branch https://github.com/MikeMcC399/github-action/tree/feat/yarn-modern for preview.) |
AtofStryker
reviewed
Mar 16, 2023
AtofStryker
approved these changes
Mar 16, 2023
@lmiller1990 do you mind taking a look at this one? |
lmiller1990
approved these changes
Mar 17, 2023
Thanks! |
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #799 "Examples for Yarn 1 (Classic) and Yarn Berry / Modern (Version 2 and later)".
It provides new examples for Yarn Classic under the directories:
examples/yarn-classic
examples/v9/yarn-classic
together with a new corresponding workflow
example-yarn-classic.yml
an update to the following script to automate maintenance updates to
cypress@latest
scripts/update-cypress-latest-other.sh
an update to cover both Yarn Classic (v1) and Yarn Modern (V2 and later) in the following file
.gitignore
and an update to
README.md
Verification
Local
nvm use 18 # for node v18.15.0 npm install yarn -g yarn -v
expect
1.22.19
Yarn Classic with Cypress 9.7.0
From root of repository ...
Confirm Cypress test passes.
Yarn Classic with Cypress 12.7.0
From root of repository ...
Update script
From root of repository ...
Confirm that Cypress has been updated to latest version (12.7.0).
GitHub
Manually run the workflow
example-yarn-classic.yml
and confirm success.