Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-14851: Fix panic in error handling #632

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ENG-14851: Fix panic in error handling #632

wants to merge 4 commits into from

Conversation

yoursnerdly
Copy link
Contributor

@yoursnerdly yoursnerdly commented Mar 8, 2025

Description of the change

HTTP error handling did not check whether the error is actually an HTTPError or not, leading to a panic in case the server is unreachable or other communication error.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Jira issue referenced in commit message and/or PR title

Testing

All acceptance tests pass.

@yoursnerdly yoursnerdly requested a review from cyral-bot as a code owner March 8, 2025 12:03
Copy link

sonarqubecloud bot commented Mar 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant