Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(cache): use os with arch for cache naming #508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Feb 4, 2025

Description

This PR makes a slight change in how caching is performed within GitHub actions to include the OS arch in addition to name. I found that the cache key name appears to overlap sometimes which can cause problems for new venv builds (for example in #506 where MacOS 14 with Python 3.11 has troubles). I'd include the runner image nickname, e.g. macos-14, but this doesn't appear to be available within the runner context. I also tried making use of $ImageOS but this doesn't appear to be available on every image (and isn't very well documented).

Should be merged prior to #506 in order to address failing job.

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

@d33bs d33bs changed the title ci(cache): use os with version for cache naming ci(cache): use os with arch for cache naming Feb 4, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (bf375ba) to head (d4f6236).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #508   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          57       57           
  Lines        3188     3188           
=======================================
  Hits         3011     3011           
  Misses        177      177           
Flag Coverage Δ
unittests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d33bs d33bs marked this pull request as ready for review February 4, 2025 18:56
@d33bs d33bs requested a review from kenibrewer February 4, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants