Ukol 3 - Vojtěch Bartoš #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barvoj
commented
Oct 21, 2016
| @@ -36,7 +36,25 @@ class User implements UserInterface | |||
| private $password; | |||
|
|
|||
| /** | |||
| * @Assert\NotBlank() | |||
There was a problem hiding this comment.
Nejsem si jistý, jak správně řešit tuto validaci když pro registraci chci aby to nebylo null ale pro editaci adresy to null naopak chci..
Barvoj
commented
Oct 21, 2016
| # The name of the route to redirect to after logging out | ||
| target: homepage | ||
|
|
||
| context: primary_auth |
There was a problem hiding this comment.
Našel jsem si, že lze sdílet context mezi více firewally. Nelíbí se mi ale, že musím u obou konfigurovat form_login i logout a jediné v čem se vlastně liší je, že tady chybí anonymous. Lze to napsat i úsporněji?
Barvoj
commented
Oct 21, 2016
| $form->handleRequest($request); | ||
| if ($form->isSubmitted() && $form->isValid()) { | ||
|
|
||
| if ($address = $user->getAddress()) { |
There was a problem hiding this comment.
Je dobře volat pokaždé persist & flush ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.