Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

A document on upgrading cassandra. #32

Merged
merged 3 commits into from
Jan 15, 2020
Merged

A document on upgrading cassandra. #32

merged 3 commits into from
Jan 15, 2020

Conversation

porridge
Copy link
Contributor

Baby step towards kudobuilder/kudo.dev#149

Note the sample output assumes that kudobuilder/kudo#1279 is already fixed.

mpereira
mpereira reviewed Jan 15, 2020
View reviewed changes
docs/upgrading.md Outdated Show resolved Hide resolved
mpereira
mpereira reviewed Jan 15, 2020
View reviewed changes
docs/upgrading.md Outdated

```

Once the pods are ready (passing readiness and liveness checks),the plan should change to `COMPLETE`.
Copy link
Contributor

@mpereira mpereira Jan 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Once the pods are ready (passing readiness and liveness checks),the plan should change to `COMPLETE`.
Once the pods are ready (passing readiness and liveness checks), the plan status should change to `COMPLETE`.

mpereira
mpereira approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@mpereira mpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @porridge!

Would you be able to standardize the formatting with ./tools/format_files.sh before merging?

@gerred gerred mentioned this pull request Jan 15, 2020
Open
6 tasks
@porridge
Copy link
Contributor Author 

./tools/format_files.sh: line 33: prettier: command not found

😭

@porridge
Copy link
Contributor Author

https://prettier.io/docs/en/install.html

$ yarn
bash: yarn: command not found
$ npm
bash: npm: command not found

😭 😭 😭

@mpereira
Copy link
Contributor

Yeah going forward there should be a development Docker image for that. The dependencies are linked from the documentation fwiw... https://github.com/mesosphere/kudo-cassandra-operator/blob/master/DEVELOPMENT.md#additional-requirements

@mpereira
Copy link
Contributor

4d528ef

@porridge
Copy link
Contributor Author

Managed to get it running using a docker container.

@porridge
Copy link
Contributor Author

Suggestions applied, PTAL

@mpereira
Copy link
Contributor

🚢

@porridge porridge merged commit 81ce93d into master Jan 15, 2020
@porridge porridge deleted the upgrading-doc branch January 15, 2020 14:44
@meichstedt meichstedt restored the upgrading-doc branch January 29, 2020 17:11
@meichstedt meichstedt deleted the upgrading-doc branch January 29, 2020 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mpereira mpereira mpereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porridge @mpereira